Description

The old copy logic relied on a copyLgTemplate api provided by @zhixzhan , however, as reported in a recent issue #2207 , after lg templates were saved in separated files, it's not capable for cross-file copy behavior anymore.

In this PR, I made a refactoring on the copy-paste flow to make the copy of actions independent from lg file structure and lg operation api.

Comparasion

Compared to the old solution that having a heavy 'paste' logic and external api dependency (copyLgTemplate):

// 1 - copy
const copy = actions => _.deepClone(actions);

// 2 - paste
const paste = actions => {
  const clonedActions = copyConstructor(actions);
  walkAdaptiveActions(
    clonedActions,
    action => {
      action.$designer = getDesigner(action.$designer.name, action.$designer.description);
      if (action.$type === 'SendActivity') {
        action.activity = copyLgTemplate(from=action.activity, to=`bfdactivity-${action.$designer.id}`);
      }
    }
  insert(dialog, actions);
}

The new solution is more similar to a real clipboard in which copied/cut actions keep real lg text:

// 1 - copy
const copy = actions => {
  const copiedActions = copyConstructor(actions);
  const dereferenceLgTemplate = lgStr => getLgTemplateBody(lgStr);
  walkAdaptiveActions(
    copiedActions,
    action => {
      if (action.$type === 'SendActivity') action.activity = dereferenceLgTemplate(action.activity);
    }
  )
}

// 2 - paste
const paste = actions => {
  const copiedActions = copyConstructor(actions);
  const buildLgReference= lgStr => updateLgTemplate(id, lgStr);
  walkAdaptiveActions(
    copiedActions,
    action => {
      if (action.$type === 'SendActivity') action.activity = buildLgReference(action.activity);
    }
  )
  insert(copiedActions);
}

The most significant difference here is when does it handle lg template references.

• in the old solution, it handles lg references during paste; it's buggy if the source actions were deleted before they were pasted.
• in the new solution
  • lg references will be dereferenced during 'copy' which means that a '${bfdactivity-1234}' string will be copied as its real value 'hello' (lgTemplate.body)
  • (Not included in this PR) Correspondingly, during 'paste', lg body string 'hello' will be transformed to a reference again by the api createLgTemplate

Benefits

1. It supports cross-file lg copy since lg body string is kept in clipboard
2. It fixes a rare user behavior: copy nodes -> delete old nodes -> paste nodes
3. It will potentially support dumping copied composer actions to plain text files & copying json in plain text file into composer

Todos in the future:

• create necessary lg templates during paste as described above (need a new createLgTemplate api @zhixzhan )
• ObiEditor.tsx is exploding, consider to extract copy/paste logic out of it.

Task Item

closes #2207
closes #2210

Screenshots